alexlebens/external-snapshotter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
a2ac03c74080597bf988d18a1927cba4d6ed55c8
external-snapshotter/client/hack
History
xing-yang a2ac03c740 Update to v3
2020-09-08 21:25:47 +00:00
..
boilerplate.go.txt
move hack to client
2020-08-14 09:40:03 +05:30
README.md
Update to v3
2020-09-08 21:25:47 +00:00
tools.go
move hack to client
2020-08-14 09:40:03 +05:30
update-crd.sh
move hack to client
2020-08-14 09:40:03 +05:30
update-generated-code.sh
Update to v3
2020-09-08 21:25:47 +00:00

README.md

Scripts User Guide

This README documents:

  • What update-crd.sh and update-generated-code.sh do
  • When and how to use them

update-generated-code.sh

This is the script to update clientset/informers/listers and API deepcopy code using code-generator.

Make sure to run this script after making changes to /client/apis/volumesnapshot/v1beta1/types.go.

Pre-requisites for running update-generated-code.sh:

git checkout v0.19.0-rc.2
  • Ensure the path exist ${GOPATH}/src/k8s.io/code-generator/generate-groups.sh

Run: ./hack/update-generated-code.sh from the client directory.

Once you run the script, you will get an output as follows:

Generating deepcopy funcs
Generating clientset for volumesnapshot:v1beta1 at github.com/kubernetes-csi/external-snapshotter/client/v3/clientset
Generating listers for volumesnapshot:v1beta1 at github.com/kubernetes-csi/external-snapshotter/client/v3/listers
Generating informers for volumesnapshot:v1beta1 at github.com/kubernetes-csi/external-snapshotter/client/v3/informers

update-crd.sh

This is the script to update CRD yaml files under /client/config/crd/ based on types.go file.

Make sure to run this script after making changes to /client/apis/volumesnapshot/v1beta1/types.go.

Follow these steps to update the CRD:

  • Run ./hack/update-crd.sh from client directory, new yaml files should have been created under ./config/crd/

  • Add api-approved.kubernetes.io annotation value in all yaml files in the metadata section with the PR where the API is approved by the API reviewers. The current approved PR for snapshot beta API is https://github.com/kubernetes-csi/external-snapshotter/pull/139. Refer to https://github.com/kubernetes/enhancements/pull/1111 for details about this annotation.

  • Remove any metadata sections from the yaml file which does not belong to the generated type. For example, the following command will add a metadata section for a nested object, remove any newly added metadata sections. TODO(xiangqian): this is to make sure the generated CRD is compatible with apiextensions.k8s.io/v1. Once controller-gen supports generating CRD with apiextensions.k8s.io/v1, switch to use the correct version of controller-gen and remove the last step from this README.

./hack/update-crd.sh; git diff
+        metadata:
+          description: 'Standard object''s metadata. More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#metadata'
  • Update the restoreSize property to string in snapshot.storage.k8s.io_volumesnapshots.yaml

The generated yaml file contains restoreSize property anyOf as described below:

            restoreSize:
              anyOf:
              - type: integer
              - type: string
              description: restoreSize represents the complete size of the snapshot
                in bytes. In dynamic snapshot creation case, this field will be filled
                in with the "size_bytes" value returned from CSI "CreateSnapshotRequest"
                gRPC call. For a pre-existing snapshot, this field will be filled
                with the "size_bytes" value returned from the CSI "ListSnapshots"
                gRPC call if the driver supports it. When restoring a volume from
                this snapshot, the size of the volume MUST NOT be smaller than the
                restoreSize if it is specified, otherwise the restoration will fail.
                If not specified, it indicates that the size is unknown.

Update the restoreSize property to use type string only:

   
            restoreSize:
              type: string
              description: restoreSize represents the complete size of the snapshot
                in bytes. In dynamic snapshot creation case, this field will be filled
                in with the "size_bytes" value returned from CSI "CreateSnapshotRequest"
                gRPC call. For a pre-existing snapshot, this field will be filled
                with the "size_bytes" value returned from the CSI "ListSnapshots"
                gRPC call if the driver supports it. When restoring a volume from
                this snapshot, the size of the volume MUST NOT be smaller than the
                restoreSize if it is specified, otherwise the restoration will fail.
                If not specified, it indicates that the size is unknown.