https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/177-volume-snapshot/tighten-validation-webhook-crd.md 1. Ratcheting validation webhook server image 2. Controller labels invalid objects 3. Unit tests for webhook 4. Deployment README and example deployment method with certs 5. Update top-level README Racheting validation: 1. webhook is strict on create 2. webhook is strict on updates where the existing object passes strict validation 3. webhook is relaxed on updates where the existing object fails strict validation (allows finalizer removal, status update, deletion, etc) Additionally the validating wehook server will perform immutability checks on scenario 2 above.
198 lines
6.2 KiB
Go
198 lines
6.2 KiB
Go
/*
|
|
Copyright 2020 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package webhook
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
"io/ioutil"
|
|
"net/http"
|
|
|
|
"github.com/spf13/cobra"
|
|
|
|
v1 "k8s.io/api/admission/v1"
|
|
"k8s.io/api/admission/v1beta1"
|
|
"k8s.io/apimachinery/pkg/runtime"
|
|
"k8s.io/klog"
|
|
// TODO: try this library to see if it generates correct json patch
|
|
// https://github.com/mattbaird/jsonpatch
|
|
)
|
|
|
|
var (
|
|
certFile string
|
|
keyFile string
|
|
port int
|
|
)
|
|
|
|
// CmdWebhook is used by agnhost Cobra.
|
|
var CmdWebhook = &cobra.Command{
|
|
Use: "validation-webhook",
|
|
Short: "Starts a HTTP server, useful for testing MutatingAdmissionWebhook and ValidatingAdmissionWebhook",
|
|
Long: `Starts a HTTP server, useful for testing MutatingAdmissionWebhook and ValidatingAdmissionWebhook.
|
|
After deploying it to Kubernetes cluster, the Administrator needs to create a ValidatingWebhookConfiguration
|
|
in the Kubernetes cluster to register remote webhook admission controllers.`,
|
|
Args: cobra.MaximumNArgs(0),
|
|
Run: main,
|
|
}
|
|
|
|
func init() {
|
|
CmdWebhook.Flags().StringVar(&certFile, "tls-cert-file", "",
|
|
"File containing the default x509 Certificate for HTTPS. (CA cert, if any, concatenated after server cert).")
|
|
CmdWebhook.Flags().StringVar(&keyFile, "tls-private-key-file", "",
|
|
"File containing the default x509 private key matching --tls-cert-file.")
|
|
CmdWebhook.Flags().IntVar(&port, "port", 443,
|
|
"Secure port that the webhook listens on")
|
|
CmdWebhook.MarkFlagRequired("tls-cert-file")
|
|
CmdWebhook.MarkFlagRequired("tls-private-key-file")
|
|
}
|
|
|
|
// admitv1beta1Func handles a v1beta1 admission
|
|
type admitv1beta1Func func(v1beta1.AdmissionReview) *v1beta1.AdmissionResponse
|
|
|
|
// admitv1beta1Func handles a v1 admission
|
|
type admitv1Func func(v1.AdmissionReview) *v1.AdmissionResponse
|
|
|
|
// admitHandler is a handler, for both validators and mutators, that supports multiple admission review versions
|
|
type admitHandler struct {
|
|
v1beta1 admitv1beta1Func
|
|
v1 admitv1Func
|
|
}
|
|
|
|
func newDelegateToV1AdmitHandler(f admitv1Func) admitHandler {
|
|
return admitHandler{
|
|
v1beta1: delegateV1beta1AdmitToV1(f),
|
|
v1: f,
|
|
}
|
|
}
|
|
|
|
func delegateV1beta1AdmitToV1(f admitv1Func) admitv1beta1Func {
|
|
return func(review v1beta1.AdmissionReview) *v1beta1.AdmissionResponse {
|
|
in := v1.AdmissionReview{Request: convertAdmissionRequestToV1(review.Request)}
|
|
out := f(in)
|
|
return convertAdmissionResponseToV1beta1(out)
|
|
}
|
|
}
|
|
|
|
// serve handles the http portion of a request prior to handing to an admit
|
|
// function
|
|
func serve(w http.ResponseWriter, r *http.Request, admit admitHandler) {
|
|
var body []byte
|
|
if r.Body == nil {
|
|
msg := "Expected request body to be non-empty"
|
|
klog.Error(msg)
|
|
http.Error(w, msg, http.StatusBadRequest)
|
|
}
|
|
|
|
data, err := ioutil.ReadAll(r.Body)
|
|
if err != nil {
|
|
msg := fmt.Sprintf("Request could not be decoded: %v", err)
|
|
klog.Error(msg)
|
|
http.Error(w, msg, http.StatusBadRequest)
|
|
}
|
|
body = data
|
|
|
|
// verify the content type is accurate
|
|
contentType := r.Header.Get("Content-Type")
|
|
if contentType != "application/json" {
|
|
msg := fmt.Sprintf("contentType=%s, expect application/json", contentType)
|
|
klog.Errorf(msg)
|
|
http.Error(w, msg, http.StatusBadRequest)
|
|
return
|
|
}
|
|
|
|
klog.V(2).Info(fmt.Sprintf("handling request: %s", body))
|
|
|
|
deserializer := codecs.UniversalDeserializer()
|
|
obj, gvk, err := deserializer.Decode(body, nil, nil)
|
|
if err != nil {
|
|
msg := fmt.Sprintf("Request could not be decoded: %v", err)
|
|
klog.Error(msg)
|
|
http.Error(w, msg, http.StatusBadRequest)
|
|
return
|
|
}
|
|
|
|
var responseObj runtime.Object
|
|
switch *gvk {
|
|
case v1beta1.SchemeGroupVersion.WithKind("AdmissionReview"):
|
|
requestedAdmissionReview, ok := obj.(*v1beta1.AdmissionReview)
|
|
if !ok {
|
|
msg := fmt.Sprintf("Expected v1beta1.AdmissionReview but got: %T", obj)
|
|
klog.Errorf(msg)
|
|
http.Error(w, msg, http.StatusBadRequest)
|
|
return
|
|
}
|
|
responseAdmissionReview := &v1beta1.AdmissionReview{}
|
|
responseAdmissionReview.SetGroupVersionKind(*gvk)
|
|
responseAdmissionReview.Response = admit.v1beta1(*requestedAdmissionReview)
|
|
responseAdmissionReview.Response.UID = requestedAdmissionReview.Request.UID
|
|
responseObj = responseAdmissionReview
|
|
case v1.SchemeGroupVersion.WithKind("AdmissionReview"):
|
|
requestedAdmissionReview, ok := obj.(*v1.AdmissionReview)
|
|
if !ok {
|
|
msg := fmt.Sprintf("Expected v1.AdmissionReview but got: %T", obj)
|
|
klog.Errorf(msg)
|
|
http.Error(w, msg, http.StatusBadRequest)
|
|
return
|
|
}
|
|
responseAdmissionReview := &v1.AdmissionReview{}
|
|
responseAdmissionReview.SetGroupVersionKind(*gvk)
|
|
responseAdmissionReview.Response = admit.v1(*requestedAdmissionReview)
|
|
responseAdmissionReview.Response.UID = requestedAdmissionReview.Request.UID
|
|
responseObj = responseAdmissionReview
|
|
default:
|
|
msg := fmt.Sprintf("Unsupported group version kind: %v", gvk)
|
|
klog.Error(msg)
|
|
http.Error(w, msg, http.StatusBadRequest)
|
|
return
|
|
}
|
|
|
|
klog.V(2).Info(fmt.Sprintf("sending response: %v", responseObj))
|
|
respBytes, err := json.Marshal(responseObj)
|
|
if err != nil {
|
|
klog.Error(err)
|
|
http.Error(w, err.Error(), http.StatusInternalServerError)
|
|
return
|
|
}
|
|
w.Header().Set("Content-Type", "application/json")
|
|
if _, err := w.Write(respBytes); err != nil {
|
|
klog.Error(err)
|
|
}
|
|
}
|
|
|
|
func serveSnapshotRequest(w http.ResponseWriter, r *http.Request) {
|
|
serve(w, r, newDelegateToV1AdmitHandler(admitSnapshot))
|
|
}
|
|
|
|
func main(cmd *cobra.Command, args []string) {
|
|
fmt.Println("Starting webhook server")
|
|
config := Config{
|
|
CertFile: certFile,
|
|
KeyFile: keyFile,
|
|
}
|
|
|
|
http.HandleFunc("/volumesnapshot", serveSnapshotRequest)
|
|
http.HandleFunc("/readyz", func(w http.ResponseWriter, req *http.Request) { w.Write([]byte("ok")) })
|
|
server := &http.Server{
|
|
Addr: fmt.Sprintf(":%d", port),
|
|
TLSConfig: configTLS(config),
|
|
}
|
|
err := server.ListenAndServeTLS("", "")
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
}
|