alexlebens/external-snapshotter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
1,231 Commits 1 Branch 0 Tags
feca95e8034cca381480e63c2238e38de5679096
Commit Graph

75 Commits

Author SHA1 Message Date
Raunak Pradip Shah
47e71db17f add comments and fix unit test 2023-12-07 09:20:11 -08:00
Raunak Pradip Shah
875662b365 Add finalizer to indicate volume snapshot is part of a group 2023-12-06 16:16:30 -08:00
Raunak Pradip Shah
060ee23d6d Delete individual volume snapshots as part of the group snapshot delete API and prevent users from deleting individual volume snapshots if it is part of an existing group snapshot 
Also revert commit bb29899ca3.
 2023-11-17 14:24:55 +05:30
Raunak Pradip Shah
facefbad6e add DeleteVolumeGroupSnapshot API to delete group snapshot 2023-11-03 13:14:00 +05:30
Shubham Pampattiwar
ff71329d8c Update VolumeSnapshot and VolumeSnapshotContent using JSON patch 
fix unit tests

operate on cloned copy

revert to update call for removeSnapshotFinalizer

fix content delete finalizer
 2023-09-15 12:17:38 -07:00
Raunak Pradip Shah
21acc924d7 Fix typos 2023-05-03 21:21:32 +05:30
Humble Chirammal
461143ec25 update client package with go 1.19 formatting changes 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2022-09-14 08:26:30 +05:30
Humble Chirammal
d34102faae make the formatting errors based on go 1.19 
Reference#
https://github.com/kubernetes-csi/csi-release-tools/pull/203

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2022-09-13 19:37:34 +05:30
Kubernetes Prow Robot
9ffdb95103 Merge pull request #690 from humblec/rbac 
replace serviceAccountName key, rbac and cleanup in the code
 2022-04-25 07:39:39 -07:00
Humble Chirammal
f30b14f8fd make use of short declaration of variables and cleanup code 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2022-04-13 08:35:03 +05:30
Raunak Pradip Shah
454fb36092 Update code with new type logic 2022-04-07 19:24:41 +05:30
Raunak Pradip Shah
5b578e8573 - Introduce new flag to enable feature to prevent unauthorised volume mode conversion 
- Changes to snapshot controller to read the volume mode from the PV and add it to SourceVolumeMode field in VolumeSnapshotContent
 2022-04-07 19:08:18 +05:30
Raunak Pradip Shah
5b3a927d2a Vendored deps 2022-03-24 21:40:29 +05:30
Raunak Pradip Shah
d300796fab - Update snapshotter module to v6 
- Update snapshotter client module to v5
- Update go version in client modules to v1.17
 2022-03-23 08:59:19 +05:30
Ubuntu
21fc337b87 feat: Implement distributed snapshotting 2021-12-24 20:03:31 +00:00
Grant Griffiths
ad7dfe6045 Revert patch for empty finalizers 
Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com>
 2021-10-05 15:38:57 -07:00
Grant Griffiths
d14e2eea8f Use patch for snapshot-controller when there are no finalizers 
- Also address PR feedback re: avoid a deepCopy for annotations patch

Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com>
 2021-09-29 16:43:02 -07:00
Grant Griffiths
e1f82e4f1a Add patch for delete annotation 
Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com>
 2021-09-28 15:54:15 -07:00
Grant Griffiths
3b9f0e2c72 Fix unit tests and don't patch with empty finalizers 
Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com>
 2021-09-28 14:29:40 -07:00
Grant Griffiths
2039ad9101 checkandBindSnapshotContent with patch tested 
Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com>
 2021-09-24 11:11:15 -07:00
Grant Griffiths
36b6b879ba add content finalizer patch 
Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com>
 2021-09-23 14:05:17 -07:00
Grant Griffiths
afff04176d WIP 
Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com>
 2021-09-23 14:05:17 -07:00
shahra
8f35f9f0d0 Update documentation for snapshot controller validation 2021-07-20 20:45:12 +05:30
Pranshu Srivastava
60824e54a5 Add "SnapshotCreated" and "SnapshotReady" events for snapshot-controller 2021-07-05 19:21:00 +05:30
Grant Griffiths
5cf92fc01a Return VolumeSnapshotContent from various functions instead of nil 
Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com>
 2021-06-14 10:47:05 -07:00
prateekpandey14
533ed886dc Move snapshot validations to validation-webhook directory 
Signed-off-by: prateekpandey14 <prateekpandey14@gmail.com>
 2021-03-14 13:39:57 +05:30
xing-yang
2a7c550b18 Change ReadyToUse in Snapshot based on caller input 
ReadyToUse in Snapshot will be updated based on ReadyToUse in Content.
ReadytoUse in Snapshot will also be updated when caller indicates it should
be changed to false when an error occurrs.
 2020-12-16 14:35:57 +00:00
xing-yang
730e6f6458 Update to client/v4 2020-12-14 18:50:10 +00:00
xing-yang
5069c99ec3 Update controller based on snapshot v1 apis 2020-12-11 21:13:47 +00:00
Grant Griffiths
941821bf99 Add snapshot controller metrics 
Signed-off-by: Grant Griffiths <grant@portworx.com>
 2020-12-02 22:18:18 -08:00
xiangqian
6f237c2a6d using csi driver from PV instead of from StorageClass 
resolve comments
 2020-12-01 17:23:35 -08:00
shahra
b9139fab75 Allow creation of snapshot content if pvc finalizer exists, 
even if pvc is marked for deletion.
 2020-10-30 18:17:32 -07:00
xing-yang
a2ac03c740 Update to v3 2020-09-08 21:25:47 +00:00
xing-yang
1ba5602b10 Add comments 2020-08-31 01:36:47 +00:00
xing-yang
c2ba707e71 Fix the race between PVC finalizer and snapshot finalizer removal 2020-08-30 02:06:14 +00:00
Andi Li
42b6b374cf Add phase 1 of validation tightening. 
https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/177-volume-snapshot/tighten-validation-webhook-crd.md

1. Ratcheting validation webhook server image
2. Controller labels invalid objects
3. Unit tests for webhook
4. Deployment README and example deployment method with certs
5. Update top-level README

Racheting validation:
1. webhook is strict on create
2. webhook is strict on updates where the existing object passes strict validation
3. webhook is relaxed on updates where the existing object fails strict validation (allows finalizer removal, status update, deletion, etc)

Additionally the validating wehook server will perform immutability
checks on scenario 2 above.
 2020-08-27 20:34:21 -04:00
Kubernetes Prow Robot
a69711cec2 Merge pull request #307 from Kartik494/updategomod 
Added go modules for Apis and Client
 2020-08-19 21:45:22 -07:00
xing-yang
2a990923fd Emit event even if status update fails so user can see it 2020-08-09 04:16:16 +00:00
kartik494
ae215218d1 Added go modules for Apis and Client 2020-07-29 16:52:45 +05:30
Christian Huffman
ffaeac1515 Move to klogv2 2020-07-27 14:39:56 -04:00
Kubernetes Prow Robot
3c32e2887b Merge pull request #334 from makkes/remove-kubernetes-dep 
chore: get rid of k8s.io/kubernetes dep
 2020-07-23 23:36:22 -07:00
Saikat Roychowdhury
73697eba81 Call dynamic VS content creation unconditionally 
Irrespective of any error on the Volume Snapshot
object, initiate dynamic VolumeSnapshotContent object
creation. If any required parameters are not found, (e.g. missing
VS class), the VS content object creation would fail gracefully.
 2020-07-23 15:14:16 +00:00
Max Jonas Werner
04848c755a chore: remove unused parameter from util funcs; add unit test 
Added the unit tests from
https://github.com/kubernetes/kubernetes/blob/master/pkg/util/slice/slice_test.go
(minus modifier tests) so we can be sure to not change behaviour.
 2020-07-22 09:36:22 +02:00
Kubernetes Prow Robot
0c5b535d88 Merge pull request #284 from xing-yang/error_status 
Update Error in Snapshot Status
 2020-07-21 22:46:05 -07:00
xing-yang
5f2090606c Update Error in Snapshot Status 2020-07-22 04:46:35 +00:00
Max Jonas Werner
1f13709413 chore: get rid of k8s.io/kubernetes dep 
This dependency is problematic because of the many replaces it brings
with it. This makes it hard to import external-snapshotter in 3rd
party projects without having a lot of `replace` directives in those
projects as well.

The only usage of that import was to get two very simple utility
functions so I copied them over to this repo.
 2020-07-21 18:23:38 +02:00
xing-yang
5800df6a61 Fix requeue logic in the common controller 2020-06-25 03:37:40 +00:00
Humble Chirammal
dcd7162224 Remove unwanted code conditions 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2020-05-04 20:57:54 +05:30
Kubernetes Prow Robot
859696c419 Merge pull request #286 from humblec/dep-update 
Update kube vendor dependency and others
 2020-05-04 05:52:26 -07:00
Humble Chirammal
b72230379f update kube and vendor dependencies 
With kubernetes 1.18 release of client-go, signatures on methods in
generated clientsets, dynamic, metadata, and scale clients have been
modified to accept context.Context as a first argument.
Signatures of Create, Update, and Patch methods have been updated
to accept CreateOptions, UpdateOptions and PatchOptions respectively.
Signatures of Delete and DeleteCollection methods now accept
DeleteOptions by value instead of by reference.
These changes are now accommodated with this PR and client-go
and dependencies are updated to v1.18.0

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2020-05-03 21:52:48 +05:30