Commit Graph

35 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
3c32e2887b Merge pull request #334 from makkes/remove-kubernetes-dep
chore: get rid of k8s.io/kubernetes dep
2020-07-23 23:36:22 -07:00
Saikat Roychowdhury
73697eba81 Call dynamic VS content creation unconditionally
Irrespective of any error on the Volume Snapshot
object, initiate dynamic VolumeSnapshotContent object
creation. If any required parameters are not found, (e.g. missing
VS class), the VS content object creation would fail gracefully.
2020-07-23 15:14:16 +00:00
Max Jonas Werner
04848c755a chore: remove unused parameter from util funcs; add unit test
Added the unit tests from
https://github.com/kubernetes/kubernetes/blob/master/pkg/util/slice/slice_test.go
(minus modifier tests) so we can be sure to not change behaviour.
2020-07-22 09:36:22 +02:00
Kubernetes Prow Robot
0c5b535d88 Merge pull request #284 from xing-yang/error_status
Update Error in Snapshot Status
2020-07-21 22:46:05 -07:00
xing-yang
5f2090606c Update Error in Snapshot Status 2020-07-22 04:46:35 +00:00
Max Jonas Werner
1f13709413 chore: get rid of k8s.io/kubernetes dep
This dependency is problematic because of the many replaces it brings
with it. This makes it hard to import external-snapshotter in 3rd
party projects without having a lot of `replace` directives in those
projects as well.

The only usage of that import was to get two very simple utility
functions so I copied them over to this repo.
2020-07-21 18:23:38 +02:00
xing-yang
5800df6a61 Fix requeue logic in the common controller 2020-06-25 03:37:40 +00:00
Humble Chirammal
dcd7162224 Remove unwanted code conditions
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2020-05-04 20:57:54 +05:30
Kubernetes Prow Robot
859696c419 Merge pull request #286 from humblec/dep-update
Update kube vendor dependency and others
2020-05-04 05:52:26 -07:00
Humble Chirammal
b72230379f update kube and vendor dependencies
With kubernetes 1.18 release of client-go, signatures on methods in
generated clientsets, dynamic, metadata, and scale clients have been
modified to accept context.Context as a first argument.
Signatures of Create, Update, and Patch methods have been updated
to accept CreateOptions, UpdateOptions and PatchOptions respectively.
Signatures of Delete and DeleteCollection methods now accept
DeleteOptions by value instead of by reference.
These changes are now accommodated with this PR and client-go
and dependencies are updated to v1.18.0

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2020-05-03 21:52:48 +05:30
zhucan
1ee21c1de5 Add event for snapshotting in progress
Signed-off-by: zhuc <zhucan@xsky.com>
2020-04-30 10:26:27 +08:00
xiangqian
45324b7a67 revamp find content logic to fix 290 291 292
add snapshot source validation in syncSnapshot
add content source validation in syncContent
2020-04-20 21:29:30 -07:00
xing-yang
c82c8e0c7e Add a check to see if PVC has a finalizer 2020-04-02 02:01:52 +00:00
xing-yang
8ae4d0c278 Check if PVC is being used by a snapshot as source 2020-04-02 01:50:19 +00:00
Christian Huffman
25b65ea8a8 Moving nil check to correct location 2020-03-19 16:21:46 -04:00
Kubernetes Prow Robot
ac3ef99c2d Merge pull request #275 from huffmanca/update_snapshotclass_deletion
Allows VolumeSnapshot to be deleted if the class isn't found
2020-03-18 17:12:43 -07:00
Christian Huffman
91a55c0e13 Allows VolumeSnapshot to be deleted if the class isn't found 2020-03-18 16:54:59 -04:00
Christian Huffman
806ccc0b29 Include a nil check for the snapshotContent 2020-03-18 13:35:25 -04:00
Grant Griffiths
9830b6ec23 Fix error check for checkandAddSnapshotFinalizers and add tests
Signed-off-by: Grant Griffiths <grant@portworx.com>
2020-03-04 10:48:16 -08:00
xing-yang
b154cc77e7 Add VolumeSnapshotBeingDeleted annotation to content 2020-02-28 18:10:20 +00:00
bells17
3b76de4999 Added the feature to use secrets of ListSnapshots 2020-02-10 11:56:47 +09:00
Alex Szakaly
fb6225dc41 fix: go module requirements for semantic versioning
This commit also adds the compatibility with dep (Go dependency
management tool) via symlink creation (same method applied in
kubernetes-csi/csi-test)

TODO: fix hack/update-generated-code.sh

Fixes issue #239.

Signed-off-by: Alex Szakaly <alex.szakaly@gmail.com>
2020-01-22 09:50:01 +01:00
xing-yang
824ce7f6c5 Remove PVC finalizer when no longer in use 2020-01-03 19:57:51 +00:00
xing-yang
6b179a5066 Address review comments 2019-12-24 14:42:06 +00:00
xing-yang
23bba14ef3 Address one more comment 2019-12-23 21:30:52 +00:00
xing-yang
37d5705019 Address review comments 2019-12-23 21:13:21 +00:00
xing-yang
29e69f4c67 Try to find content from store by key before searching thru the list 2019-12-23 20:13:03 +00:00
xing-yang
bf48d62ab5 Don't trigger content deletion if snapshot is nil 2019-12-23 20:13:03 +00:00
xing-yang
62d9ab547e Address review comments 2019-12-23 20:13:03 +00:00
xing-yang
0ac299cf77 Add a function needsUpdateSnapshotStatus 2019-12-23 20:13:03 +00:00
xing-yang
f2814e5a18 Address review comments 2019-12-23 20:13:03 +00:00
xing-yang
d4350943e2 Update snapshot controller 2019-12-23 20:13:03 +00:00
Grant Griffiths
b5f2165795 Fix err shadow in updateSnapshotStatus and add retry delay
Signed-off-by: Grant Griffiths <grant@portworx.com>
2019-12-20 09:47:42 -08:00
xing-yang
9000e9c846 Address review comments 2019-11-08 02:46:17 +00:00
xing-yang
6308420635 Split snapshot controller using beta APIs 2019-11-07 16:49:41 +00:00