Commit Graph

27 Commits

Author SHA1 Message Date
Max Jonas Werner
04848c755a chore: remove unused parameter from util funcs; add unit test
Added the unit tests from
https://github.com/kubernetes/kubernetes/blob/master/pkg/util/slice/slice_test.go
(minus modifier tests) so we can be sure to not change behaviour.
2020-07-22 09:36:22 +02:00
Max Jonas Werner
1f13709413 chore: get rid of k8s.io/kubernetes dep
This dependency is problematic because of the many replaces it brings
with it. This makes it hard to import external-snapshotter in 3rd
party projects without having a lot of `replace` directives in those
projects as well.

The only usage of that import was to get two very simple utility
functions so I copied them over to this repo.
2020-07-21 18:23:38 +02:00
Christian Huffman
daf0051f2b Updated sidecar to not require VolumeSnapshotClass for snapshot deletion 2020-06-04 17:16:45 -04:00
xing-yang
cbd5b8b7a1 Add requeue in sidecar 2020-05-09 21:36:16 +00:00
Humble Chirammal
dcd7162224 Remove unwanted code conditions
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2020-05-04 20:57:54 +05:30
Humble Chirammal
b72230379f update kube and vendor dependencies
With kubernetes 1.18 release of client-go, signatures on methods in
generated clientsets, dynamic, metadata, and scale clients have been
modified to accept context.Context as a first argument.
Signatures of Create, Update, and Patch methods have been updated
to accept CreateOptions, UpdateOptions and PatchOptions respectively.
Signatures of Delete and DeleteCollection methods now accept
DeleteOptions by value instead of by reference.
These changes are now accommodated with this PR and client-go
and dependencies are updated to v1.18.0

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2020-05-03 21:52:48 +05:30
xing-yang
f688d7baef Remove error status check 2020-04-03 18:34:57 +00:00
xing-yang
2295e6aea3 Add error status check in createSnapshotWrapper 2020-04-03 01:53:04 +00:00
xing-yang
9f382acd43 Address review comments 2020-04-02 14:23:08 +00:00
xing-yang
f32313bdb8 checkandUpdateContentStatusOperation should not call createSnapshotOperation 2020-04-02 14:23:08 +00:00
xing-yang
0189c77f5a Check final error 2020-04-02 14:23:08 +00:00
xing-yang
6ca7507bc3 Address review comments 2020-04-02 14:23:08 +00:00
xing-yang
7930dd261d Check error code DeadlineExceeded 2020-04-02 14:23:08 +00:00
xing-yang
aa2bc2fb9c Remove the unnecessary driver name check 2020-04-02 14:23:08 +00:00
xing-yang
4c38cc8c6e Remove VolumeSnapshotBeingCreated annotation after driver response 2020-04-02 14:23:08 +00:00
xing-yang
313507f866 Add AnnVolumeSnapshotBeingCreated 2020-04-02 14:23:08 +00:00
Grant Griffiths
fe1c355fa9 Add more sidecar tests and cleanup sidecar code
Signed-off-by: Grant Griffiths <grant@portworx.com>
2020-03-04 20:30:45 -08:00
bells17
7cbcf6aa41 Fix log messages and error messages 2020-02-21 00:42:15 +09:00
bells17
dd390a3e38 Improve error messages 2020-02-20 01:09:40 +09:00
bells17
401732912f Improve error messages 2020-02-19 20:19:37 +09:00
bells17
3b76de4999 Added the feature to use secrets of ListSnapshots 2020-02-10 11:56:47 +09:00
Alex Szakaly
fb6225dc41 fix: go module requirements for semantic versioning
This commit also adds the compatibility with dep (Go dependency
management tool) via symlink creation (same method applied in
kubernetes-csi/csi-test)

TODO: fix hack/update-generated-code.sh

Fixes issue #239.

Signed-off-by: Alex Szakaly <alex.szakaly@gmail.com>
2020-01-22 09:50:01 +01:00
xing-yang
1ca3435c43 Check ReadyToUse in sidecar 2019-12-30 04:41:01 +00:00
xiangqian
b747de45c5 sidecar controller update, fix potential snapshot leaking
resolve comments
2019-12-17 15:17:31 -08:00
Gábor Lipták
8542d1fc7a Correct typo 2019-11-14 09:38:41 -05:00
xing-yang
9000e9c846 Address review comments 2019-11-08 02:46:17 +00:00
xing-yang
6308420635 Split snapshot controller using beta APIs 2019-11-07 16:49:41 +00:00