- Needed to start the http server outside of pkg/metric
- We needed this because we want to add other endpoints to the server
Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com>
The webhook image needlessly used the distroless image containing glibc.
The webhook server is a static binary, so it can be packaged using the
distroless/static image like the other components.
This patch adds two new parameters `retryIntervalStart & retryIntervalMax`
which can be configured to adjust the ratelimiters of snapshotqueue and contentqueue
in the controller.
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
```release-note
`retry-interval-start` and `retry-interval-max` arguments are added to common-controller
which controls retry interval of failed volume snapshot creation and deletion.
These values set the ratelimiter for snapshot and content queues.
```
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Two new timeout values ( retryIntervalStart & retryIntervalMax )
have been added to set the ratelimiter for volumesnapshotcontent queue.
Fix# https://github.com/kubernetes-csi/external-snapshotter/issues/463
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
```release-note
`retry-interval-start` and `retry-interval-max` arguments are added to csi-snapshotter sidecar which controls retry interval of failed volume snapshot creation and deletion. These values set the ratelimiter for volumesnapshotcontent queue.
```
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/177-volume-snapshot/tighten-validation-webhook-crd.md
1. Ratcheting validation webhook server image
2. Controller labels invalid objects
3. Unit tests for webhook
4. Deployment README and example deployment method with certs
5. Update top-level README
Racheting validation:
1. webhook is strict on create
2. webhook is strict on updates where the existing object passes strict validation
3. webhook is relaxed on updates where the existing object fails strict validation (allows finalizer removal, status update, deletion, etc)
Additionally the validating wehook server will perform immutability
checks on scenario 2 above.
This commit also adds the compatibility with dep (Go dependency
management tool) via symlink creation (same method applied in
kubernetes-csi/csi-test)
TODO: fix hack/update-generated-code.sh
Fixes issue #239.
Signed-off-by: Alex Szakaly <alex.szakaly@gmail.com>
preserveUnknownField set to false, comments updates, adding pull request annotation
more comment updates
VolumeSnapshot comments
rename to VolumeSnapshotClassName
adding license
connectionTimeout is deprecated in favor of
csiTimeout, logging connectionTimeout wont
look good as this doesnot have any effect
in NewSnapshotter.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Ubuntu
Lintong Jiang
Grant Griffiths
Fabio Bertinatto
Moritz "WanzenBug" Wanzenböck
shahra
Humble Chirammal
Mauricio Poppe
xing-yang
Grant Griffiths
namrata-ibm
Chris Henzie
Andi Li
Kubernetes Prow Robot
kartik494
Christian Huffman
Patrick Ohly
ialidzhikov
Alex Szakaly
saad-ali
Madhu Rajanna
zhucan