Madhu Rajanna
5a7115d61d
Add snapshot size to VSC created for VGS
...
Currently the RestoreSize is missing when
the corresponding VSC are created for the
the volumesnapshotgroup, This PR adds the missing
RestoreSize for VSC.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2024-02-14 15:39:17 +01:00
xing-yang
3ed4ebd3d8
Use client v7
2024-01-30 17:40:58 -05:00
Raunak Pradip Shah
060ee23d6d
Delete individual volume snapshots as part of the group snapshot delete API and prevent users from deleting individual volume snapshots if it is part of an existing group snapshot
...
Also revert commit bb29899ca3
.
2023-11-17 14:24:55 +05:30
Jan Safranek
8a29bf5b21
Re-queue SnapshotContents that are readyToUse: false
...
SnapshotContents with readyToUse: false should be periodically requeued
with exp. backoff until the CSI driver confirms the snapshot is ready.
2023-11-16 15:37:48 +01:00
Shubham Pampattiwar
ff71329d8c
Update VolumeSnapshot and VolumeSnapshotContent using JSON patch
...
fix unit tests
operate on cloned copy
revert to update call for removeSnapshotFinalizer
fix content delete finalizer
2023-09-15 12:17:38 -07:00
Humble Chirammal
d34102faae
make the formatting errors based on go 1.19
...
Reference#
https://github.com/kubernetes-csi/csi-release-tools/pull/203
Signed-off-by: Humble Chirammal <hchiramm@redhat.com >
2022-09-13 19:37:34 +05:30
Humble Chirammal
f30b14f8fd
make use of short declaration of variables and cleanup code
...
Signed-off-by: Humble Chirammal <hchiramm@redhat.com >
2022-04-13 08:35:03 +05:30
Raunak Pradip Shah
5b3a927d2a
Vendored deps
2022-03-24 21:40:29 +05:30
Raunak Pradip Shah
d300796fab
- Update snapshotter module to v6
...
- Update snapshotter client module to v5
- Update go version in client modules to v1.17
2022-03-23 08:59:19 +05:30
Grant Griffiths
f3d345340e
Fix an issue where patch will fail when status is nil
...
Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com >
2021-10-20 19:36:48 -07:00
Grant Griffiths
d14e2eea8f
Use patch for snapshot-controller when there are no finalizers
...
- Also address PR feedback re: avoid a deepCopy for annotations patch
Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com >
2021-09-29 16:43:02 -07:00
Grant Griffiths
b2d17cd6bb
setAnnVolumeSnapshotBeingCreated patch impl
...
Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com >
2021-09-28 17:40:55 -07:00
Grant Griffiths
afff04176d
WIP
...
Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com >
2021-09-23 14:05:17 -07:00
Grant Griffiths
5cf92fc01a
Return VolumeSnapshotContent from various functions instead of nil
...
Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com >
2021-06-14 10:47:05 -07:00
Christian Huffman
c554274833
Correct snapshotContent error propagation
2021-04-21 18:38:40 -04:00
Timo Reimann
b31a29fd83
Retain CreateSnapshot error
...
The error returned from CreateSnapshot was overwritten by the call to
removeAnnVolumeSnapshotBeingCreated. Retain the error through variable
shadowing so that it can be propagated and reported upwards the call
stack.
We also improve the error line by dropping an unnecessary comma and
dequoting the error string (since we already employ a colon separator).
2021-02-07 21:58:37 +01:00
xing-yang
730e6f6458
Update to client/v4
2020-12-14 18:50:10 +00:00
xing-yang
5069c99ec3
Update controller based on snapshot v1 apis
2020-12-11 21:13:47 +00:00
Christian Huffman
0f3fa91d0b
Don't check for snapshotClass when deleting content
2020-11-06 15:43:45 -05:00
Chris Henzie
f705b23bbd
Pass snapshot metadata to CSI driver
2020-10-09 12:53:32 -07:00
xing-yang
a2ac03c740
Update to v3
2020-09-08 21:25:47 +00:00
Kubernetes Prow Robot
a69711cec2
Merge pull request #307 from Kartik494/updategomod
...
Added go modules for Apis and Client
2020-08-19 21:45:22 -07:00
xing-yang
2a990923fd
Emit event even if status update fails so user can see it
2020-08-09 04:16:16 +00:00
kartik494
ae215218d1
Added go modules for Apis and Client
2020-07-29 16:52:45 +05:30
Christian Huffman
ffaeac1515
Move to klogv2
2020-07-27 14:39:56 -04:00
Max Jonas Werner
04848c755a
chore: remove unused parameter from util funcs; add unit test
...
Added the unit tests from
https://github.com/kubernetes/kubernetes/blob/master/pkg/util/slice/slice_test.go
(minus modifier tests) so we can be sure to not change behaviour.
2020-07-22 09:36:22 +02:00
Max Jonas Werner
1f13709413
chore: get rid of k8s.io/kubernetes dep
...
This dependency is problematic because of the many replaces it brings
with it. This makes it hard to import external-snapshotter in 3rd
party projects without having a lot of `replace` directives in those
projects as well.
The only usage of that import was to get two very simple utility
functions so I copied them over to this repo.
2020-07-21 18:23:38 +02:00
Christian Huffman
daf0051f2b
Updated sidecar to not require VolumeSnapshotClass for snapshot deletion
2020-06-04 17:16:45 -04:00
xing-yang
cbd5b8b7a1
Add requeue in sidecar
2020-05-09 21:36:16 +00:00
Humble Chirammal
dcd7162224
Remove unwanted code conditions
...
Signed-off-by: Humble Chirammal <hchiramm@redhat.com >
2020-05-04 20:57:54 +05:30
Humble Chirammal
b72230379f
update kube and vendor dependencies
...
With kubernetes 1.18 release of client-go, signatures on methods in
generated clientsets, dynamic, metadata, and scale clients have been
modified to accept context.Context as a first argument.
Signatures of Create, Update, and Patch methods have been updated
to accept CreateOptions, UpdateOptions and PatchOptions respectively.
Signatures of Delete and DeleteCollection methods now accept
DeleteOptions by value instead of by reference.
These changes are now accommodated with this PR and client-go
and dependencies are updated to v1.18.0
Signed-off-by: Humble Chirammal <hchiramm@redhat.com >
2020-05-03 21:52:48 +05:30
xing-yang
f688d7baef
Remove error status check
2020-04-03 18:34:57 +00:00
xing-yang
2295e6aea3
Add error status check in createSnapshotWrapper
2020-04-03 01:53:04 +00:00
xing-yang
9f382acd43
Address review comments
2020-04-02 14:23:08 +00:00
xing-yang
f32313bdb8
checkandUpdateContentStatusOperation should not call createSnapshotOperation
2020-04-02 14:23:08 +00:00
xing-yang
0189c77f5a
Check final error
2020-04-02 14:23:08 +00:00
xing-yang
6ca7507bc3
Address review comments
2020-04-02 14:23:08 +00:00
xing-yang
7930dd261d
Check error code DeadlineExceeded
2020-04-02 14:23:08 +00:00
xing-yang
aa2bc2fb9c
Remove the unnecessary driver name check
2020-04-02 14:23:08 +00:00
xing-yang
4c38cc8c6e
Remove VolumeSnapshotBeingCreated annotation after driver response
2020-04-02 14:23:08 +00:00
xing-yang
313507f866
Add AnnVolumeSnapshotBeingCreated
2020-04-02 14:23:08 +00:00
Grant Griffiths
fe1c355fa9
Add more sidecar tests and cleanup sidecar code
...
Signed-off-by: Grant Griffiths <grant@portworx.com >
2020-03-04 20:30:45 -08:00
bells17
7cbcf6aa41
Fix log messages and error messages
2020-02-21 00:42:15 +09:00
bells17
dd390a3e38
Improve error messages
2020-02-20 01:09:40 +09:00
bells17
401732912f
Improve error messages
2020-02-19 20:19:37 +09:00
bells17
3b76de4999
Added the feature to use secrets of ListSnapshots
2020-02-10 11:56:47 +09:00
Alex Szakaly
fb6225dc41
fix: go module requirements for semantic versioning
...
This commit also adds the compatibility with dep (Go dependency
management tool) via symlink creation (same method applied in
kubernetes-csi/csi-test)
TODO: fix hack/update-generated-code.sh
Fixes issue #239 .
Signed-off-by: Alex Szakaly <alex.szakaly@gmail.com >
2020-01-22 09:50:01 +01:00
xing-yang
1ca3435c43
Check ReadyToUse in sidecar
2019-12-30 04:41:01 +00:00
xiangqian
b747de45c5
sidecar controller update, fix potential snapshot leaking
...
resolve comments
2019-12-17 15:17:31 -08:00
Gábor Lipták
8542d1fc7a
Correct typo
2019-11-14 09:38:41 -05:00