alexlebens/external-snapshotter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
1,300 Commits 1 Branch 0 Tags
master
Commit Graph

89 Commits

Author SHA1 Message Date
Connor Catlett
35579f2803 Discard unnecessary VolumeSnapshotContent updates to prevent rapid RPC calls 
Signed-off-by: Connor Catlett <conncatl@amazon.com>
 2024-02-29 18:42:37 +00:00
Madhu Rajanna
5706ab6ac8 use GroupSnapshotDeleteError type for event 
use GroupSnapshotDeleteError as event type for
event incase if there is any failure in delete
operation.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2024-02-20 08:43:14 +01:00
Madhu Rajanna
0fe3abb9f1 fix method name in logging 
updating code to use correct method
names for logging.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2024-02-20 08:41:14 +01:00
Madhu Rajanna
5a7115d61d Add snapshot size to VSC created for VGS 
Currently the RestoreSize is missing when
the corresponding VSC are created for the
the volumesnapshotgroup, This PR adds the missing
RestoreSize for VSC.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2024-02-14 15:39:17 +01:00
xing-yang
3ed4ebd3d8 Use client v7 2024-01-30 17:40:58 -05:00
Niels de Vos
d0f443f564 implement GroupSnapshotter.GetGroupSnapshotStatus() 2024-01-30 09:22:07 +01:00
Raunak Pradip Shah
e6dc65fefe Fix unit test and remove comments 2024-01-08 10:12:47 -08:00
Raunak Pradip Shah
0bd355cf29 update API names in group snapshot content to be consistent with volume snapshots 2024-01-05 11:29:51 -08:00
Raunak Pradip Shah
875662b365 Add finalizer to indicate volume snapshot is part of a group 2023-12-06 16:16:30 -08:00
Raunak Pradip Shah
060ee23d6d Delete individual volume snapshots as part of the group snapshot delete API and prevent users from deleting individual volume snapshots if it is part of an existing group snapshot 
Also revert commit bb29899ca3.
 2023-11-17 14:24:55 +05:30
Jan Safranek
8a29bf5b21 Re-queue SnapshotContents that are readyToUse: false 
SnapshotContents with readyToUse: false should be periodically requeued
with exp. backoff until the CSI driver confirms the snapshot is ready.
 2023-11-16 15:37:48 +01:00
Jan Safranek
f9e125b994 Check sync error in unit test properly 
Tests must fail when syncContent() returns success and error was expected.
 2023-11-16 15:37:48 +01:00
Raunak Pradip Shah
42151b59aa change VolumeGroupSnapshotContentName to VolumeGroupSnapshotHandle in snapshot content status 2023-11-08 12:06:06 +05:30
Raunak Pradip Shah
facefbad6e add DeleteVolumeGroupSnapshot API to delete group snapshot 2023-11-03 13:14:00 +05:30
Shubham Pampattiwar
ff71329d8c Update VolumeSnapshot and VolumeSnapshotContent using JSON patch 
fix unit tests

operate on cloned copy

revert to update call for removeSnapshotFinalizer

fix content delete finalizer
 2023-09-15 12:17:38 -07:00
Sameer Shaikh
7fac9cdaf8 external-snapshotter constantly retrying CreateSnapshot calls on error w/o backoff 2023-06-29 21:17:27 +05:30
Sameer Shaikh
d8e698f609 external-snapshotter constantly retrying CreateSnapshot calls on error w/o backoff 2023-06-29 08:03:57 +05:30
Sameer Shaikh
ffaba0f81d external-snapshotter constantly retrying CreateSnapshot calls on error w/o backoff 2023-06-28 18:32:07 +05:30
Sameer Shaikh
a8c9b7b644 external-snapshotter constantly retrying CreateSnapshot calls on error w/o backoff 2023-06-28 15:59:21 +05:30
Sameer Shaikh
98939c02c5 external-snapshotter constantly retrying CreateSnapshot calls on error w/o backoff 
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
 2023-06-28 13:17:42 +05:30
Raunak Pradip Shah
21acc924d7 Fix typos 2023-05-03 21:21:32 +05:30
Raunak Pradip Shah
65fbb48cd7 Change timestamp format in volumesnapshot and content names 2023-05-03 21:21:32 +05:30
Raunak Pradip Shah
80893cb871 Add hash of PVC UUID to group snapshot names 2023-05-03 21:21:32 +05:30
Raunak Pradip Shah
e26501e510 Add reference details to volume group snapshot content status 2023-05-03 21:21:32 +05:30
Raunak Pradip Shah
9e2d4f6264 Add groupSnapshotNamePrefix and groupSnapshotNameUUIDLength CLI options 2023-05-03 21:21:32 +05:30
Raunak Pradip Shah
d8d01a38e4 Change all occurences of content to group snapshot content 2023-05-03 21:21:32 +05:30
Raunak Pradip Shah
871312988b Added create group volume snapshot functionality 2023-05-03 21:21:32 +05:30
Raunak Pradip Shah
299862c783 Add csi snapshotter functionality for volume group snapshots 2023-05-03 21:21:32 +05:30
Humble Chirammal
d34102faae make the formatting errors based on go 1.19 
Reference#
https://github.com/kubernetes-csi/csi-release-tools/pull/203

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2022-09-13 19:37:34 +05:30
Humble Chirammal
f30b14f8fd make use of short declaration of variables and cleanup code 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2022-04-13 08:35:03 +05:30
Raunak Pradip Shah
5b3a927d2a Vendored deps 2022-03-24 21:40:29 +05:30
Raunak Pradip Shah
d300796fab - Update snapshotter module to v6 
- Update snapshotter client module to v5
- Update go version in client modules to v1.17
 2022-03-23 08:59:19 +05:30
Peter Schuurman
497a316b04 Bugfix: Check if newSnapContent.Status is set before checking if Status.Error is present 2022-03-08 09:06:37 -08:00
Peter Schuurman
edf2e03f35 Allow resync on pvc when there is no error on the object 2022-03-02 11:26:16 -08:00
zhucan
e46df1bdab external-snapshotter constantly retrying CreateSnapshot calls on error w/o backoff 
Signed-off-by: zhucan <zhucan.k8s@gmail.com>
 2022-02-14 10:38:57 +08:00
Grant Griffiths
f3d345340e Fix an issue where patch will fail when status is nil 
Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com>
 2021-10-20 19:36:48 -07:00
Grant Griffiths
d14e2eea8f Use patch for snapshot-controller when there are no finalizers 
- Also address PR feedback re: avoid a deepCopy for annotations patch

Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com>
 2021-09-29 16:43:02 -07:00
Grant Griffiths
b2d17cd6bb setAnnVolumeSnapshotBeingCreated patch impl 
Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com>
 2021-09-28 17:40:55 -07:00
Grant Griffiths
3b9f0e2c72 Fix unit tests and don't patch with empty finalizers 
Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com>
 2021-09-28 14:29:40 -07:00
Grant Griffiths
afff04176d WIP 
Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com>
 2021-09-23 14:05:17 -07:00
Grant Griffiths
0476dcedcc Refactor http server and register leaderelection health check 
- Needed to start the http server outside of pkg/metric
- We needed this because we want to add other endpoints to the server

Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com>
 2021-08-10 11:44:12 -07:00
Kubernetes Prow Robot
d6d967c79d Merge pull request #527 from ggriffiths/removeannvs_beingcreated_returncontent 
Return VolumeSnapshotContent from various functions instead of nil
 2021-06-17 01:54:18 -07:00
Grant Griffiths
5cf92fc01a Return VolumeSnapshotContent from various functions instead of nil 
Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com>
 2021-06-14 10:47:05 -07:00
Humble Chirammal
9f7f993c50 Add ability to customize VolumeSnapshotContent workqueue 
Two new timeout values ( retryIntervalStart & retryIntervalMax )
have been added to set the ratelimiter for volumesnapshotcontent queue.

Fix# https://github.com/kubernetes-csi/external-snapshotter/issues/463

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>

```release-note
 `retry-interval-start` and `retry-interval-max` arguments are added to csi-snapshotter sidecar which controls retry interval of failed volume snapshot creation and deletion. These values set the ratelimiter for volumesnapshotcontent queue.
```

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2021-06-10 19:12:12 +05:30
Christian Huffman
c554274833 Correct snapshotContent error propagation 2021-04-21 18:38:40 -04:00
Timo Reimann
b31a29fd83 Retain CreateSnapshot error 
The error returned from CreateSnapshot was overwritten by the call to
removeAnnVolumeSnapshotBeingCreated. Retain the error through variable
shadowing so that it can be propagated and reported upwards the call
stack.

We also improve the error line by dropping an unnecessary comma and
dequoting the error string (since we already employ a colon separator).
 2021-02-07 21:58:37 +01:00
xing-yang
730e6f6458 Update to client/v4 2020-12-14 18:50:10 +00:00
xing-yang
5069c99ec3 Update controller based on snapshot v1 apis 2020-12-11 21:13:47 +00:00
Christian Huffman
0f3fa91d0b Don't check for snapshotClass when deleting content 2020-11-06 15:43:45 -05:00
Chris Henzie
f705b23bbd Pass snapshot metadata to CSI driver 2020-10-09 12:53:32 -07:00