56 Commits

Author SHA1 Message Date
Baptiste Girard-Carrabin
72b51c066c [snapshot-controller] Fix wait for CRDs duration
Ensure the function `ensureCustomResourceDefinitionsExist` returns when
the duration specified in `retryCRDIntervalMax` flag is reached.
This works by passing a context to the backoff so that we can
timeout with context.WithTimeout. The new (correct) default duration for
the flag is 30s to give a bit more time when controller and CRD are
created at the same time.
Also limit the amount of resources returned by the list calls to 0 to
speed up the operations because we only care that the CRD exists.
2024-01-10 10:36:55 +01:00
Alex Kalenyuk
895dc73977 Enable prevent-volume-mode-conversion by default following k8s 1.28 release
This is beta since 1.27 so we can safely default to true, to get this new validation logic.
https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/3141-prevent-volume-mode-conversion/kep.yaml#L30

Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
2023-12-10 14:23:29 +02:00
Matthew Cary
0cd8f738c7 Parameterize startup CRD wait retries
Change-Id: I870a3d294b4d30abea3f6ecad951d68cfd5c9ceb
2022-11-03 18:23:31 -07:00
Kartik Sharma
302073a050 Update README.md
Co-authored-by: Grant Griffiths <ggp493@gmail.com>
2022-08-04 18:05:32 +05:30
kartik494
e6e4784a37 Improve README 2022-08-04 10:50:56 +05:30
Raunak Pradip Shah
c645e43b1b Update README with prevent-volume-mode-conversion feature flag 2022-04-21 10:45:06 +05:30
Shawn Hurley
d8a31738f1 Adding documentation for the validations that the webhook performs 2022-04-13 09:56:44 -04:00
Shawn Hurley
4f783f10fc Updating readme based on new flag for webhook
* Adding volumesnapshotclasses to admission configuration template
2022-04-07 10:39:24 -04:00
Ubuntu
21fc337b87 feat: Implement distributed snapshotting 2021-12-24 20:03:31 +00:00
Kubernetes Prow Robot
070312031a Merge pull request #621 from lintongj/configurable-qps-and-burst
Make the QPS and Burst of kube client config to be configurable
2021-12-07 11:58:36 -08:00
Lintong Jiang
f3136decb3 Make the QPS and Burst of kube client config to be configurable in both csi-snapshotter and snapshot-controller 2021-12-07 10:28:36 -08:00
itspngu
98085c7b30 update usage instructions 2021-11-22 13:57:07 +00:00
xing-yang
1449bcbb7f Add changelog for 4.2 2021-08-16 03:27:57 +00:00
ialidzhikov
0ad035eac9 Clean up .travis.yml
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
2021-08-10 22:10:35 +03:00
Fabio Bertinatto
22d4998b4c Add options to configure leader election in snapshot-controller 2021-08-09 16:01:41 -03:00
Chris Henzie
ac99c8df9e Fix recommended Kubernetes version in README
This should be the lowest Kubernetes version needed where all its
supported features will function correctly.

See for more details:
https://kubernetes-csi.github.io/docs/project-policies.html#recommended-version
2021-08-04 18:12:35 -07:00
Chris Henzie
5d2a22be7b Update README for compatible CSI spec 2021-08-04 15:38:51 -07:00
shahra
db972e7c50 Add command line arguments to configure leader election options 2021-06-25 11:38:58 +05:30
Humble Chirammal
206fecb9f1 Allow tuning Common-controller Ratelimiter with retryIntervalStart & retryIntervalMax
This patch adds two new parameters `retryIntervalStart & retryIntervalMax`
which can be configured to adjust the ratelimiters of snapshotqueue and contentqueue
in the controller.

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>

```release-note
 `retry-interval-start` and `retry-interval-max` arguments are added to common-controller
  which controls retry interval of failed volume snapshot creation and deletion.
  These values set the ratelimiter for snapshot and content queues.
```

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2021-06-11 23:29:17 +05:30
Kubernetes Prow Robot
af117aad81 Merge pull request #308 from humblec/ratelimiter
Add ability to customize VolumeSnapshotContent workqueue
2021-06-10 11:55:27 -07:00
Humble Chirammal
de7589cf03 Correct CRD installation in the doc
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2021-06-10 19:15:22 +05:30
Humble Chirammal
9f7f993c50 Add ability to customize VolumeSnapshotContent workqueue
Two new timeout values ( retryIntervalStart & retryIntervalMax )
have been added to set the ratelimiter for volumesnapshotcontent queue.

Fix# https://github.com/kubernetes-csi/external-snapshotter/issues/463

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>

```release-note
 `retry-interval-start` and `retry-interval-max` arguments are added to csi-snapshotter sidecar which controls retry interval of failed volume snapshot creation and deletion. These values set the ratelimiter for volumesnapshotcontent queue.
```

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2021-06-10 19:12:12 +05:30
xing-yang
2dd41b5888 Fix README 2021-04-30 14:15:54 +00:00
xing-yang
d6f21422bc Add changelog for 4.1.0 2021-04-30 02:56:32 +00:00
xing-yang
53d6d330ac Clarify instructions about validation webhook 2020-12-18 15:36:43 +00:00
xing-yang
7e83f249ae Update README 2020-12-18 04:09:43 +00:00
Grant Griffiths
997795d872 Increase resync-period default to 15 minutes
Signed-off-by: Grant Griffiths <grant@portworx.com>
2020-12-09 23:11:12 -08:00
xing-yang
6761111167 Bump csi-lib-utils to v0.9.0 2020-12-05 02:39:03 +00:00
Manohar Reddy
5d52b742cd add instructions on creating volume snapshot quota for CRs 2020-10-30 14:44:25 +05:30
Manohar Reddy
731f1401ba update hyperlink for snaphshot validation webhook 2020-10-09 11:39:44 +05:30
xing-yang
154db5477e Add changelog for release 3.0.0 2020-09-17 03:42:35 +00:00
Kubernetes Prow Robot
4f3b02aaa0 Merge pull request #353 from AndiLi99/AndiLi99/webhook
Add snapshot webhook build and deployment. Modify controller to label invalid objects.
2020-08-28 18:51:19 -07:00
Andi Li
8e8ab7b7c7 Documentation style match new line after bullet point. 2020-08-28 12:11:20 -04:00
Andi Li
06989d7897 Update documentation.
Minor cleanup and change default fail policy and timeout on webhook
config.
2020-08-28 12:06:28 -04:00
Kubernetes Prow Robot
6838d02ff4 Merge pull request #369 from humblec/new
Update the CSI spec support matrix
2020-08-27 20:15:01 -07:00
Andi Li
42b6b374cf Add phase 1 of validation tightening.
https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/177-volume-snapshot/tighten-validation-webhook-crd.md

1. Ratcheting validation webhook server image
2. Controller labels invalid objects
3. Unit tests for webhook
4. Deployment README and example deployment method with certs
5. Update top-level README

Racheting validation:
1. webhook is strict on create
2. webhook is strict on updates where the existing object passes strict validation
3. webhook is relaxed on updates where the existing object fails strict validation (allows finalizer removal, status update, deletion, etc)

Additionally the validating wehook server will perform immutability
checks on scenario 2 above.
2020-08-27 20:34:21 -04:00
Humble Chirammal
0ca9b6dace Update the CSI spec support matrix
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2020-08-27 18:42:36 +05:30
Madhu Rajanna
ac6cf6d258 update readme for new crd directory
as the CRD directory is changed now,
the readme should point to the new directory
where the CRD is present.
2020-08-20 10:36:51 +05:30
Jason Taylor
0802d19711 Doc updates for controller namespace
Make all namespace settings explicit and add more documentation around
setting appropriate namespace when installing.
2020-05-13 07:07:25 -04:00
ialidzhikov
d1330389c5 Nit: fix typos
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
2020-04-26 23:43:15 +03:00
Jan Safranek
34a9687303 Add links to version in README
To clarify what the version means.
2020-04-15 20:02:59 +02:00
xing-yang
b4f4f16805 Changelog for 2.1 release 2020-04-03 23:50:10 +00:00
wangzheng03
a2979dfd15 fix link 2020-01-20 09:46:45 +08:00
saad-ali
d705c40e17 Fix typo in readme 2020-01-02 11:25:49 -08:00
saad-ali
3173a1fb35 Introduce metrics library 2019-12-30 16:37:11 -08:00
xing-yang
b3e25bda7b Add a warning msg in the upgrade process 2019-12-20 14:54:06 +00:00
xing-yang
710319e6d7 Update README 2019-12-20 00:44:48 +00:00
Nolan Brubaker
0f67d8d2e1 Update README to reflect go module usage
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-12-09 15:40:37 -05:00
Andrew Sy Kim
2e2058d559 update README, examples and RBAC to include leader election 2019-04-08 10:23:31 -04:00
Humble Chirammal
0421d1dc7a Correct markdown linter errors.
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2019-01-11 16:03:32 +05:30