Add more sidecar tests and cleanup sidecar code
Signed-off-by: Grant Griffiths <grant@portworx.com>
This commit is contained in:
Grant Griffiths
@@ -17,32 +17,168 @@ limitations under the License.
|
||||
package sidecar_controller
|
||||
|
||||
import (
|
||||
"errors"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
crdv1 "github.com/kubernetes-csi/external-snapshotter/v2/pkg/apis/volumesnapshot/v1beta1"
|
||||
"github.com/kubernetes-csi/external-snapshotter/v2/pkg/utils"
|
||||
v1 "k8s.io/api/core/v1"
|
||||
)
|
||||
|
||||
func TestSyncContent(t *testing.T) {
|
||||
var tests []controllerTest
|
||||
|
||||
tests = append(tests, controllerTest{
|
||||
name: "Basic content update ready to use",
|
||||
initialContents: newContentArrayWithReadyToUse("content1-1", "snapuid1-1", "snap1-1", "sid1-1", defaultClass, "", "volume-handle-1-1", retainPolicy, nil, &defaultSize, &False, true),
|
||||
expectedContents: newContentArrayWithReadyToUse("content1-1", "snapuid1-1", "snap1-1", "sid1-1", defaultClass, "", "volume-handle-1-1", retainPolicy, nil, &defaultSize, &True, true),
|
||||
expectedEvents: noevents,
|
||||
expectedCreateCalls: []createCall{
|
||||
{
|
||||
volumeHandle: "volume-handle-1-1",
|
||||
snapshotName: "snapshot-snapuid1-1",
|
||||
driverName: mockDriverName,
|
||||
snapshotId: "snapuid1-1",
|
||||
creationTime: timeNow,
|
||||
readyToUse: true,
|
||||
tests := []controllerTest{
|
||||
{
|
||||
name: "1-1: Basic content update ready to use",
|
||||
initialContents: newContentArrayWithReadyToUse("content1-1", "snapuid1-1", "snap1-1", "sid1-1", defaultClass, "", "volume-handle-1-1", retainPolicy, nil, &defaultSize, &False, true),
|
||||
expectedContents: newContentArrayWithReadyToUse("content1-1", "snapuid1-1", "snap1-1", "sid1-1", defaultClass, "", "volume-handle-1-1", retainPolicy, nil, &defaultSize, &True, true),
|
||||
expectedEvents: noevents,
|
||||
expectedCreateCalls: []createCall{
|
||||
{
|
||||
volumeHandle: "volume-handle-1-1",
|
||||
snapshotName: "snapshot-snapuid1-1",
|
||||
driverName: mockDriverName,
|
||||
snapshotId: "snapuid1-1",
|
||||
creationTime: timeNow,
|
||||
readyToUse: true,
|
||||
},
|
||||
},
|
||||
expectedListCalls: []listCall{{"sid1-1", map[string]string{}, true, time.Now(), 1, nil}},
|
||||
errors: noerrors,
|
||||
test: testSyncContent,
|
||||
},
|
||||
expectedListCalls: []listCall{{"sid1-1", map[string]string{}, true, time.Now(), 1, nil}},
|
||||
errors: noerrors,
|
||||
test: testSyncContent,
|
||||
})
|
||||
{
|
||||
name: "1-2: Basic sync content create snapshot",
|
||||
initialContents: withContentStatus(newContentArray("content1-2", "snapuid1-2", "snap1-2", "sid1-2", defaultClass, "", "volume-handle-1-2", retainPolicy, nil, &defaultSize, true),
|
||||
nil),
|
||||
expectedContents: withContentStatus(newContentArray("content1-2", "snapuid1-2", "snap1-2", "sid1-2", defaultClass, "", "volume-handle-1-2", retainPolicy, nil, &defaultSize, true),
|
||||
&crdv1.VolumeSnapshotContentStatus{SnapshotHandle: toStringPointer("snapuid1-2"), RestoreSize: &defaultSize, ReadyToUse: &True}),
|
||||
expectedEvents: noevents,
|
||||
expectedCreateCalls: []createCall{
|
||||
{
|
||||
volumeHandle: "volume-handle-1-2",
|
||||
snapshotName: "snapshot-snapuid1-2",
|
||||
driverName: mockDriverName,
|
||||
snapshotId: "snapuid1-2",
|
||||
creationTime: timeNow,
|
||||
readyToUse: true,
|
||||
size: defaultSize,
|
||||
},
|
||||
},
|
||||
expectedListCalls: []listCall{{"sid1-2", map[string]string{}, true, time.Now(), 1, nil}},
|
||||
errors: noerrors,
|
||||
test: testSyncContent,
|
||||
},
|
||||
{
|
||||
name: "1-3: Basic sync content create snapshot with non-existent secret",
|
||||
initialContents: withContentAnnotations(withContentStatus(newContentArray("content1-3", "snapuid1-3", "snap1-3", "sid1-3", invalidSecretClass, "", "volume-handle-1-3", retainPolicy, nil, &defaultSize, true),
|
||||
nil), map[string]string{
|
||||
utils.AnnDeletionSecretRefName: "",
|
||||
utils.AnnDeletionSecretRefNamespace: "",
|
||||
}),
|
||||
expectedContents: withContentAnnotations(withContentStatus(newContentArray("content1-3", "snapuid1-3", "snap1-3", "sid1-3", invalidSecretClass, "", "volume-handle-1-3", retainPolicy, nil, &defaultSize, true),
|
||||
&crdv1.VolumeSnapshotContentStatus{
|
||||
SnapshotHandle: nil,
|
||||
RestoreSize: nil,
|
||||
ReadyToUse: &False,
|
||||
Error: newSnapshotError("Failed to create snapshot: failed to get input parameters to create snapshot for content content1-3: \"cannot retrieve secrets for snapshot content \\\"content1-3\\\", err: secret name or namespace not specified\""),
|
||||
}), map[string]string{
|
||||
utils.AnnDeletionSecretRefName: "",
|
||||
utils.AnnDeletionSecretRefNamespace: "",
|
||||
}), initialSecrets: []*v1.Secret{}, // no initial secret created
|
||||
expectedEvents: []string{"Warning SnapshotCreationFailed"},
|
||||
errors: noerrors,
|
||||
test: testSyncContent,
|
||||
},
|
||||
{
|
||||
name: "1-4: Basic sync content create snapshot with valid secret",
|
||||
initialContents: withContentAnnotations(withContentStatus(newContentArray("content1-4", "snapuid1-4", "snap1-4", "sid1-4", validSecretClass, "", "volume-handle-1-4", retainPolicy, nil, &defaultSize, true),
|
||||
nil), map[string]string{
|
||||
utils.AnnDeletionSecretRefName: "secret",
|
||||
utils.AnnDeletionSecretRefNamespace: "default",
|
||||
}),
|
||||
expectedContents: withContentAnnotations(withContentStatus(newContentArray("content1-4", "snapuid1-4", "snap1-4", "sid1-4", validSecretClass, "", "volume-handle-1-4", retainPolicy, nil, &defaultSize, true),
|
||||
&crdv1.VolumeSnapshotContentStatus{
|
||||
SnapshotHandle: toStringPointer("snapuid1-4"),
|
||||
RestoreSize: &defaultSize,
|
||||
ReadyToUse: &True,
|
||||
Error: nil,
|
||||
}), map[string]string{
|
||||
utils.AnnDeletionSecretRefName: "secret",
|
||||
utils.AnnDeletionSecretRefNamespace: "default",
|
||||
}),
|
||||
expectedCreateCalls: []createCall{
|
||||
{
|
||||
volumeHandle: "volume-handle-1-4",
|
||||
snapshotName: "snapshot-snapuid1-4",
|
||||
parameters: class5Parameters,
|
||||
secrets: map[string]string{
|
||||
"foo": "bar",
|
||||
},
|
||||
driverName: mockDriverName,
|
||||
snapshotId: "snapuid1-4",
|
||||
creationTime: timeNow,
|
||||
readyToUse: true,
|
||||
size: defaultSize,
|
||||
},
|
||||
},
|
||||
initialSecrets: []*v1.Secret{secret()},
|
||||
expectedEvents: noevents,
|
||||
errors: noerrors,
|
||||
test: testSyncContent,
|
||||
},
|
||||
{
|
||||
name: "1-5: Basic sync content create snapshot with failed secret call",
|
||||
initialContents: withContentAnnotations(withContentStatus(newContentArray("content1-5", "snapuid1-5", "snap1-5", "sid1-5", invalidSecretClass, "", "volume-handle-1-5", retainPolicy, nil, &defaultSize, true),
|
||||
nil), map[string]string{
|
||||
utils.AnnDeletionSecretRefName: "secret",
|
||||
utils.AnnDeletionSecretRefNamespace: "default",
|
||||
}),
|
||||
expectedContents: withContentAnnotations(withContentStatus(newContentArray("content1-5", "snapuid1-5", "snap1-5", "sid1-5", invalidSecretClass, "", "volume-handle-1-5", retainPolicy, nil, &defaultSize, true),
|
||||
&crdv1.VolumeSnapshotContentStatus{
|
||||
SnapshotHandle: nil,
|
||||
RestoreSize: nil,
|
||||
ReadyToUse: &False,
|
||||
Error: newSnapshotError("Failed to create snapshot: failed to get input parameters to create snapshot for content content1-5: \"cannot get credentials for snapshot content \\\"content1-5\\\"\""),
|
||||
}), map[string]string{
|
||||
utils.AnnDeletionSecretRefName: "secret",
|
||||
utils.AnnDeletionSecretRefNamespace: "default",
|
||||
}), initialSecrets: []*v1.Secret{}, // no initial secret created
|
||||
expectedEvents: []string{"Warning SnapshotCreationFailed"},
|
||||
errors: []reactorError{
|
||||
// Inject error to the first client.VolumesnapshotV1beta1().VolumeSnapshots().Update call.
|
||||
// All other calls will succeed.
|
||||
{"get", "secrets", errors.New("mock secrets error")},
|
||||
},
|
||||
test: testSyncContent,
|
||||
},
|
||||
{
|
||||
name: "1-6: Basic content update ready to use bad snapshot class",
|
||||
initialContents: newContentArrayWithReadyToUse("content1-6", "snapuid1-6", "snap1-6", "sid1-6", "bad-class", "", "volume-handle-1-6", retainPolicy, nil, &defaultSize, &False, true),
|
||||
expectedContents: withContentStatus(newContentArray("content1-6", "snapuid1-6", "snap1-6", "sid1-6", "bad-class", "", "volume-handle-1-6", retainPolicy, nil, &defaultSize, true),
|
||||
&crdv1.VolumeSnapshotContentStatus{
|
||||
SnapshotHandle: toStringPointer("sid1-6"),
|
||||
RestoreSize: &defaultSize,
|
||||
ReadyToUse: &False,
|
||||
Error: newSnapshotError("Failed to check and update snapshot content: failed to get input parameters to create snapshot content1-6: \"failed to retrieve snapshot class bad-class from the informer: \\\"volumesnapshotclass.snapshot.storage.k8s.io \\\\\\\"bad-class\\\\\\\" not found\\\"\""),
|
||||
}),
|
||||
expectedEvents: []string{"Warning SnapshotContentCheckandUpdateFailed"},
|
||||
expectedCreateCalls: []createCall{
|
||||
{
|
||||
volumeHandle: "volume-handle-1-6",
|
||||
snapshotName: "snapshot-snapuid1-6",
|
||||
driverName: mockDriverName,
|
||||
snapshotId: "snapuid1-6",
|
||||
creationTime: timeNow,
|
||||
readyToUse: true,
|
||||
},
|
||||
},
|
||||
expectedListCalls: []listCall{{"sid1-6", map[string]string{}, true, time.Now(), 1, nil}},
|
||||
errors: noerrors,
|
||||
test: testSyncContent,
|
||||
},
|
||||
}
|
||||
|
||||
runSyncContentTests(t, tests, snapshotClasses)
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user