From 3309c8ae5a039b4cf521ca918b6b3614d8195ef7 Mon Sep 17 00:00:00 2001 From: Raunak Pradip Shah Date: Fri, 18 Nov 2022 14:32:51 +0530 Subject: [PATCH 1/3] Add volume mode conversion flag to manifests --- .../snapshot-controller/setup-snapshot-controller.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/deploy/kubernetes/snapshot-controller/setup-snapshot-controller.yaml b/deploy/kubernetes/snapshot-controller/setup-snapshot-controller.yaml index cd5b8683..152a615e 100644 --- a/deploy/kubernetes/snapshot-controller/setup-snapshot-controller.yaml +++ b/deploy/kubernetes/snapshot-controller/setup-snapshot-controller.yaml @@ -37,4 +37,5 @@ spec: args: - "--v=5" - "--leader-election=true" + - "--prevent-volume-mode-conversion=false" imagePullPolicy: IfNotPresent From 9d4ad3f9261c28af8fc4933d3279b2215a4fa12c Mon Sep 17 00:00:00 2001 From: Raunak Pradip Shah Date: Tue, 29 Nov 2022 10:10:33 +0530 Subject: [PATCH 2/3] Add marker --- .../snapshot-controller/setup-snapshot-controller.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deploy/kubernetes/snapshot-controller/setup-snapshot-controller.yaml b/deploy/kubernetes/snapshot-controller/setup-snapshot-controller.yaml index 152a615e..0bc195cd 100644 --- a/deploy/kubernetes/snapshot-controller/setup-snapshot-controller.yaml +++ b/deploy/kubernetes/snapshot-controller/setup-snapshot-controller.yaml @@ -37,5 +37,5 @@ spec: args: - "--v=5" - "--leader-election=true" - - "--prevent-volume-mode-conversion=false" + # end snapshot controller args imagePullPolicy: IfNotPresent From 8cc3b4dfcf6013fadc1889776e2df5d2650dd826 Mon Sep 17 00:00:00 2001 From: Raunak Pradip Shah Date: Tue, 3 Jan 2023 10:39:50 +0530 Subject: [PATCH 3/3] Add marker description --- .../snapshot-controller/setup-snapshot-controller.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/deploy/kubernetes/snapshot-controller/setup-snapshot-controller.yaml b/deploy/kubernetes/snapshot-controller/setup-snapshot-controller.yaml index 0bc195cd..b4136e01 100644 --- a/deploy/kubernetes/snapshot-controller/setup-snapshot-controller.yaml +++ b/deploy/kubernetes/snapshot-controller/setup-snapshot-controller.yaml @@ -37,5 +37,7 @@ spec: args: - "--v=5" - "--leader-election=true" + # Add a marker to the snapshot-controller manifests. This is needed to enable feature gates in CSI prow jobs. + # For example, in https://github.com/kubernetes-csi/csi-release-tools/pull/209, the snapshot-controller YAML is updated to add --prevent-volume-mode-conversion=true so that the feature can be enabled for certain e2e tests. # end snapshot controller args imagePullPolicy: IfNotPresent