alexlebens/external-snapshotter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't trigger content deletion if snapshot is nil

Browse Source
This commit is contained in:
xing-yang
2019-12-19 15:55:18 +00:00
parent 62d9ab547e
commit bf48d62ab5
1 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
pkg/common-controller/snapshot_controller.go
View File

@@ -126,16 +126,24 @@ func (ctrl *csiSnapshotCommonController) syncContent(content *crdv1.VolumeSnapsh
} }
} }
// Trigger content deletion if snapshot is nil or snapshot has // NOTE(xyang): Do not trigger content deletion if
// deletion timestamp. // snapshot is nil. This is to avoid data loss if
// the user copied the yaml files and expect it to work
// in a different setup. In this case snapshot is nil.
// If we trigger content deletion, it will delete
// physical snapshot resource on the storage system
// and result in data loss!
//
// Trigger content deletion if snapshot is not nil
// and snapshot has deletion timestamp.
// If snapshot has deletion timestamp and finalizers, set // If snapshot has deletion timestamp and finalizers, set
// AnnVolumeSnapshotBeingDeleted annotation on the content. // AnnVolumeSnapshotBeingDeleted annotation on the content.
// This may trigger the deletion of the content in the // This may trigger the deletion of the content in the
// sidecar controller depending on the deletion policy // sidecar controller depending on the deletion policy
// on the content. // on the content.
// Snapshot won't be deleted until content is deleted // Snapshot won't be deleted until content is deleted
// due to the finalizer // due to the finalizer.
if snapshot == nil || utils.IsSnapshotDeletionCandidate(snapshot) { if snapshot != nil && utils.IsSnapshotDeletionCandidate(snapshot) {
err = ctrl.setAnnVolumeSnapshotBeingDeleted(content) err = ctrl.setAnnVolumeSnapshotBeingDeleted(content)
if err != nil { if err != nil {
return err return err