From 98939c02c5a78238c40aa9928ff4c80b4e70ebde Mon Sep 17 00:00:00 2001 From: Sameer Shaikh Date: Wed, 28 Jun 2023 12:55:20 +0530 Subject: [PATCH] external-snapshotter constantly retrying CreateSnapshot calls on error w/o backoff Signed-off-by: Sameer Shaikh --- pkg/sidecar-controller/snapshot_controller_base.go | 5 ----- 1 file changed, 5 deletions(-) diff --git a/pkg/sidecar-controller/snapshot_controller_base.go b/pkg/sidecar-controller/snapshot_controller_base.go index ecb7ecd8..852b54a9 100644 --- a/pkg/sidecar-controller/snapshot_controller_base.go +++ b/pkg/sidecar-controller/snapshot_controller_base.go @@ -124,12 +124,7 @@ func NewCSISnapshotSideCarController( // So we are skipping the re-queue here to avoid CreateSnapshot being called without exponential backoff. newSnapContent := newObj.(*crdv1.VolumeSnapshotContent) if newSnapContent.Status != nil && newSnapContent.Status.Error != nil { - oldSnapContent := oldObj.(*crdv1.VolumeSnapshotContent) - _, newExists := newSnapContent.ObjectMeta.Annotations[utils.AnnVolumeSnapshotBeingCreated] - _, oldExists := oldSnapContent.ObjectMeta.Annotations[utils.AnnVolumeSnapshotBeingCreated] - if !newExists && oldExists { return - } } ctrl.enqueueContentWork(newObj) },