From 7cbcf6aa41e7511c8d022414e259f7f7df9fe5f5 Mon Sep 17 00:00:00 2001 From: bells17 Date: Fri, 21 Feb 2020 00:42:15 +0900 Subject: [PATCH] Fix log messages and error messages --- pkg/sidecar-controller/snapshot_controller.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/pkg/sidecar-controller/snapshot_controller.go b/pkg/sidecar-controller/snapshot_controller.go index 085f16f9..bf02e70b 100644 --- a/pkg/sidecar-controller/snapshot_controller.go +++ b/pkg/sidecar-controller/snapshot_controller.go @@ -260,21 +260,21 @@ func (ctrl *csiSnapshotSideCarController) checkandUpdateContentStatusOperation(c if content.Spec.VolumeSnapshotClassName != nil { class, err := ctrl.getSnapshotClass(*content.Spec.VolumeSnapshotClassName) if err != nil { - klog.Errorf("Failed to get snapshot class %s for snapshot content %s", *content.Spec.VolumeSnapshotClassName, err) - return nil, fmt.Errorf("failed to get snapshot class %s for snapshot content %s", *content.Spec.VolumeSnapshotClassName, err) + klog.Errorf("Failed to get snapshot class %s for snapshot content %s: %v", *content.Spec.VolumeSnapshotClassName, content.Name, err) + return nil, fmt.Errorf("failed to get snapshot class %s for snapshot content %s: %v", *content.Spec.VolumeSnapshotClassName, content.Name, err) } snapshotterListSecretRef, err := utils.GetSecretReference(utils.SnapshotterListSecretParams, class.Parameters, content.GetObjectMeta().GetName(), nil) if err != nil { - klog.Errorf("Failed to get secret reference for snapshot %s: %s", content.Name, err) - return nil, fmt.Errorf("failed to get secret reference for snapshot %s: %s", content.Name, err) + klog.Errorf("Failed to get secret reference for snapshot content %s: %v", content.Name, err) + return nil, fmt.Errorf("failed to get secret reference for snapshot content %s: %v", content.Name, err) } snapshotterListCredentials, err = utils.GetCredentials(ctrl.client, snapshotterListSecretRef) if err != nil { // Continue with deletion, as the secret may have already been deleted. - klog.Errorf("Failed to get credentials for snapshot %s: %s", content.Name, err) - return nil, fmt.Errorf("failed to get credentials for snapshot %s: %s", content.Name, err) + klog.Errorf("Failed to get credentials for snapshot content %s: %v", content.Name, err) + return nil, fmt.Errorf("failed to get credentials for snapshot content %s: %v", content.Name, err) } }