alexlebens/external-snapshotter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add feature flag

Browse Source
This commit is contained in:
Raunak Pradip Shah
2022-04-19 15:58:09 +05:30
parent bb13123906
commit 24bbdae16f
2 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
pkg/validation-webhook/snapshot.go
View File

@@ -377,8 +377,11 @@ func checkSnapshotContentImmutableFieldsV1(snapcontent, oldSnapcontent *volumesn
if !reflect.DeepEqual(source.SnapshotHandle, oldSource.SnapshotHandle) { if !reflect.DeepEqual(source.SnapshotHandle, oldSource.SnapshotHandle) {
return fmt.Errorf("Spec.Source.SnapshotHandle is immutable but was changed from %s to %s", strPtrDereference(oldSource.SnapshotHandle), strPtrDereference(source.SnapshotHandle)) return fmt.Errorf("Spec.Source.SnapshotHandle is immutable but was changed from %s to %s", strPtrDereference(oldSource.SnapshotHandle), strPtrDereference(source.SnapshotHandle))
} }
if !reflect.DeepEqual(snapcontent.Spec.SourceVolumeMode, oldSnapcontent.Spec.SourceVolumeMode) {
return fmt.Errorf("Spec.SourceVolumeMode is immutable but was changed from %v to %v", *oldSnapcontent.Spec.SourceVolumeMode, *snapcontent.Spec.SourceVolumeMode) if preventVolumeModeConversion {
if !reflect.DeepEqual(snapcontent.Spec.SourceVolumeMode, oldSnapcontent.Spec.SourceVolumeMode) {
return fmt.Errorf("Spec.SourceVolumeMode is immutable but was changed from %v to %v", *oldSnapcontent.Spec.SourceVolumeMode, *snapcontent.Spec.SourceVolumeMode)
}
} }
return nil return nil

11
pkg/validation-webhook/webhook.go
View File

@@ -39,10 +39,11 @@ import (
) )
var ( var (
certFile string certFile string
keyFile string keyFile string
kubeconfigFile string kubeconfigFile string
port int port int
preventVolumeModeConversion bool
) )
// CmdWebhook is used by Cobra. // CmdWebhook is used by Cobra.
@@ -67,6 +68,8 @@ func init() {
CmdWebhook.MarkFlagRequired("tls-private-key-file") CmdWebhook.MarkFlagRequired("tls-private-key-file")
// Add optional flag for kubeconfig // Add optional flag for kubeconfig
CmdWebhook.Flags().StringVar(&kubeconfigFile, "kubeconfig", "", "kubeconfig file to use for volumesnapshotclasses") CmdWebhook.Flags().StringVar(&kubeconfigFile, "kubeconfig", "", "kubeconfig file to use for volumesnapshotclasses")
CmdWebhook.Flags().BoolVar(&preventVolumeModeConversion, "prevent-volume-mode-conversion",
false, "Prevents an unauthorised user from modifying the volume mode when creating a PVC from an existing VolumeSnapshot.")
} }
// admitv1beta1Func handles a v1beta1 admission // admitv1beta1Func handles a v1beta1 admission